Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build module - single item build, existing items movement #542

Merged
merged 20 commits into from
Nov 29, 2018
Merged

Build module - single item build, existing items movement #542

merged 20 commits into from
Nov 29, 2018

Conversation

veteran29
Copy link
Member

@veteran29 veteran29 commented Nov 29, 2018 •
edited
Loading

Q A
Bug fix? no
New feature? no
Needs wipe? no
Fixed issues #523

Description:

Further development of build module.

Content:

  • Close camera when player unit dies
  • Add an API for "single item build"
    • Build FOB via "single item build"
  • Initial draft for build display toolbox/topbar with buttons
    • Movement of placed objects, initial implementation via button in toolbox
  • Units will look in correct direction after build/load
  • Moved items build confirmation into separate method
  • Added KPLIB_build_item_built_local event, KPLIB_build_item_built is global now

Additional content

  • core_getNearestSector refactored into core_getNearestMarker
  • Simplified core_buildFob into a "system" function used only for fob marker creation handling
  • Improved core_canBuildFob
  • Player fob build action handled via event "KPLIB_fob_build_requested"
  • Fixed core vehicle spawn actions not added to saved vehicles

Successfully tested on:

  • Local MP Vanilla
  • Dedicated MP Vanilla

Compatibility checked with:

  • Nothing

@veteran29
Move build confirm to separate method, handle unit direction
c1b2d09
@veteran29
Global KPLIB_build_item_built event, initialize handlers where needed
b81768b
@veteran29
Stop build on death
c9d7d9c
@veteran29
Add IDC to build background
3983c5f
@veteran29
Add KPLIB_build_item_built_local event
2a683c8
@veteran29
Single item building initial implementation
f6d35de
@veteran29
Simplify build FOB
bea0061
@veteran29
Refactor core_getNearestSector into core_getNearestMarker
03030d1
@veteran29
Fix public variable on location type
392c59e
@veteran29
Core vehicle handlers should be added in preInit
18d6035
@veteran29
Register build module as FOB building provider
a2ce5bc
@veteran29
Consume FOB container/truck instead of deleting freshly built FOB house
9e4ec7e
@veteran29
Improve build list height config
cd054c4
@veteran29
Add toolbox to build display, toolbox queue mode change button
0585949
@veteran29
Add build_confirmSingle, fix local event being fired on server
3bdee68
@veteran29
Fix missing "class" keyword in functions.hpp
a086e04
@veteran29
build_confirmSingle documentation
c9dbe4b
@veteran29
Create FOB on server
ef96a6f
@veteran29 veteran29 changed the title V0.97 s8 523 Build module - single item build, existing items movement Nov 29, 2018
@veteran29 veteran29 self-assigned this Nov 29, 2018
@veteran29 veteran29 added this to the Sprint 8 milestone Nov 29, 2018
Dubjunk
Dubjunk previously approved these changes Nov 29, 2018
View reviewed changes
Wyqer
Wyqer requested changes Nov 29, 2018
View reviewed changes
Copy link
Member

@Wyqer Wyqer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks in general good to me, but haven't had a look at it in the game itself. I'm confident it'll be nice from the look&feel, too.
Overall I recognized that there could be slightly more commenting at some code areas.
But well, it was very late ^^

Missionframework/modules/04_build/fnc/fn_build_confirmAll.sqf Outdated Show resolved Hide resolved
Missionframework/modules/02_core/fnc/fn_core_canBuildFob.sqf Outdated Show resolved Hide resolved
Missionframework/modules/02_core/fnc/fn_core_getNearestMarker.sqf Outdated Show resolved Hide resolved
Missionframework/modules/02_core/fnc/fn_core_getNearestMarker.sqf Outdated Show resolved Hide resolved
Missionframework/modules/02_core/fnc/fn_core_handleVehicleSpawn.sqf Show resolved Hide resolved
Missionframework/modules/02_core/fnc/fn_core_setupPlayerActions.sqf Show resolved Hide resolved
Missionframework/modules/04_build/fnc/fn_build_preInit.sqf Show resolved Hide resolved
@Wyqer
Copy link
Member

Wyqer commented Nov 29, 2018

In-game review things I've encountered by testing the current state (should be adressed in S9):

  • Limited zeus without free cam usage on the Liberty will set you under water and you can't rise due to the height restriction. This should be estimated from player position, not at z0.
  • After spawning the following function log message appears:
    activateaddons
  • Build menu panel on the left side could get a slightly offset from the borders. Looks cut off currently
  • (not build menu) Redeploy action appears doubled in action menu, when in FOB or at Liberty and go near the Potato 01. Also the action from the Potato 01 is localized on the server and not on the client.

@veteran29 veteran29 merged commit f6f07de into v0.97S8 Nov 29, 2018
@Wyqer Wyqer added done and removed review/QA labels Nov 29, 2018
@Wyqer Wyqer deleted the v0.97S8-523 branch November 29, 2018 14:46
@Wyqer Wyqer mentioned this pull request Nov 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyqer Wyqer Wyqer approved these changes

@Dubjunk Dubjunk Dubjunk approved these changes

Assignees

@veteran29 veteran29

Labels
None yet
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
3 participants
@veteran29 @Wyqer @Dubjunk